Return time as Date instance #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Node returns time in KeyBlock and MicroBlockHeader as Date Apply a change ```diff -const time = new Date( - (await node.getTopHeader()).time, -); +const time = (await node.getTopHeader()).time; ```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2010 +/- ##
===========================================
+ Coverage 84.37% 84.52% +0.15%
===========================================
Files 106 106
Lines 3495 3497 +2
Branches 729 730 +1
===========================================
+ Hits 2949 2956 +7
+ Misses 452 447 -5
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found issues aeternity/ae_mdw#1891 aeternity/ae_mdw#1901 aeternity/aeternity#4386
This PR is supported by the Æternity Foundation