Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name history panel should be visible with no data #127

Closed
michele-franchi opened this issue Apr 18, 2023 · 4 comments
Closed

Name history panel should be visible with no data #127

michele-franchi opened this issue Apr 18, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@michele-franchi
Copy link
Collaborator

Context information

application version:
device:
browser:
operating system:

Steps to reproduce

  • Open a name details page, example
  • Scroll down to "History"

What is expected?

  • The panel should be visible even with no data, for example:

image

What is actually happening?

image

@michele-franchi michele-franchi added the bug Something isn't working label Apr 18, 2023
@janmichek
Copy link
Collaborator

I guess we will need more elaboration for that. Probably does not work at given circumstances. In 99% it works https://aescan.dev.aepps.com/names/b.chain

@michele-franchi
Copy link
Collaborator Author

@janmichek you are probably not able to replicate it because the name history table always has at least one event, NameClaimEvent. I think this happens when the call fails, so you don't get any data, and I was experiencing this during a test.

@lukeromanowicz lukeromanowicz self-assigned this Apr 27, 2023
@lukeromanowicz
Copy link
Contributor

@michele-franchi Looking at the code it should be impossible to get such a result. I will need a test subject because I'm out of ideas about what could cause this.

@lukeromanowicz lukeromanowicz changed the title Name history panel should be visible with no data [repro needed] Name history panel should be visible with no data Apr 28, 2023
@lukeromanowicz lukeromanowicz changed the title [repro needed] Name history panel should be visible with no data Name history panel should be visible with no data May 1, 2023
@lukeromanowicz
Copy link
Contributor

I reproduced the issue through throwing an error during fetching name activity

@lukeromanowicz lukeromanowicz closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants