fix: handle name history api errors #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-189-aescan.stg.aepps.com |
|
Honestly, I don't see a need for this fix. It's a hypothetical scenario with no evidence of happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #127
Doesn't show the name history tab if loading failed.
I decided to go this path rather than displaying "There is no data available" because so far we have been showing that message when there is no data available in the blockchain. In this case there always is data but fetching it fails. I think it should be handled differently (e.g. some appropriate message that loading data failed, please try again later). Probably will be improved everywhere across the application in #95
Demo
Checklist: