-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Wallet account view 4 #678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally it looks good but I would adjust the following:
- The "Connect Wallet" button should have the same height of the network switcher:
padding: var(--space-1);
on the button solves it.
- The "Exit Wallet" dropdown should be visually similar to the menu dropdowns.
Example:
Without the min-width of the other menu items.
- When you connect the wallet and you refresh the page the connection is lost.
I have been discussing this with Denis. Currently is not possible to achieve this seamlessly. The app can remember last used account, but we cannot go over the user prompt to connect to the wallet again like on superhero.com For now, I suggest not to implement it, wait for SDK completion, and the implement the persistency of last logged address @michele-franchi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Description
fixes #536
There are 2 minor UX issues I will try to resolve in the following (Portfolio) issue, so I don't block the review
Demo
firefox_BZzKh8r8cp.mp4
Checklist: