Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Wallet portfolio #810

Closed
wants to merge 35 commits into from
Closed

feat: Wallet portfolio #810

wants to merge 35 commits into from

Conversation

janmichek
Copy link
Collaborator

Description

resolves #550

Demo

Checklist:

  • I have read and followed the Contributing Guide
  • add wallet connection
  • show basic wallet info

janmichek added 30 commits May 23, 2024 13:27
@janmichek
add basic wallet connection
5d13f9d
@janmichek
fix header styles
bd91ef9
@janmichek
add basic connection UI
3f9afab
@janmichek
componentize UI
5d5f0c5
@janmichek
print basic account information
d40bb98
@janmichek
fix scanning wallet
ab76025
@janmichek
add hint
bc7128a
@janmichek
add disconnect action
7f98917
@janmichek
display all account information
e46c0fd
@janmichek
create dropdown UI
4e04e9b
@janmichek
fix header controls
2dbe581
@janmichek
fix css selector
ed88ec5
@janmichek
fix network id connection
0e0a4c9
@janmichek
extend button UI
d62b77f
@janmichek
detect denied status
a72bfeb
@janmichek
handle denied state
472e719
@janmichek
fix imports
0064c93
@janmichek
fix loading transitions
1cc7275
@janmichek
fix connection controls
d561be6
@janmichek
change button style
f985c39
@janmichek
remove comments
f3c0b1b
@janmichek
remove unused code
0e5e40a
@janmichek
update navigation when wallet changed
946bfd1
@janmichek
add portfolio layout
e5b8dac
@janmichek
fix imports
2a9f16b
@janmichek
fix code style
a4e6a61
@janmichek
fixes after rebase
40824d5
@janmichek
fixes after rebase
acad242
@janmichek
fix buttons
0f0d7fc
@janmichek
fix code style
86d5fbc
@janmichek janmichek changed the title Wallet portfolio feat: Wallet portfolio May 23, 2024
@github-actions GitHub Actions
Copy link

Deployed to https://pr-810-aescan.stg.service.aepps.com and https://pr-810-aescan-testnet.stg.service.aepps.com

@janmichek janmichek mentioned this pull request May 23, 2024
Closed
39 tasks
@janmichek janmichek requested a review from Liubov-crypto July 17, 2024 13:43
@Liubov-crypto
Copy link
Collaborator

  1. Missing spacing
    port

  2. Missing arrows everywhere:
    keybl
    arrrows

  3. Missing icons:

icons
on prod:

midd

  1. After I disconnected the wallet:
    exit wallet

  2. Aligning and columns are shifted:

2024-07-18.12.04.48.mov
  1. Sometimes it's hard to choose the first tab from the drop down list:
2024-07-18.12.09.20.mov

Liubov-crypto
Liubov-crypto suggested changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek please check it

@janmichek janmichek closed this Jul 18, 2024
@janmichek
Copy link
Collaborator Author

@janmichek please check it

@Liubov-crypto Sorry, I accidentally assigned you to a wrong PR. My fault. Here is the correct one #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet portfolio
2 participants
@janmichek @Liubov-crypto