feat: Store transaction page/cursor in url of accounts page #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
janmichek
force-pushed
the
Store-transaction-page-cursor-in-url-of-accounts-page
branch
from
7333de8 to
40186a4
Compare
janmichek
force-pushed
the
Store-transaction-page-cursor-in-url-of-accounts-page
branch
from
b4cb70b to
a04b7de
Compare
janmichek
deleted the
Store-transaction-page-cursor-in-url-of-accounts-page
branch
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #462
I choose store solution rather than project the current state to url.
It resolved the annoying UX, but it's nothing advanced. As you see in the demo, the tx data is a snapshot from the initial access to the page. EG: You go 3 pages Next, you go 3 pages back (even tho there has been new transactions created).
Some advanced solution would require page index information from MDW. Currently, we count the page index on FE. So for the case going back from detail to listing, the app will lose information about the current page index.
I don't think such a solution is good.
I also recommend checking reference explorers, how they solve it. They have more simplistic solution
Demo
firefox_kEXrjsnl2M.mp4
Checklist: