Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Store transaction page/cursor in url of accounts page #811

Closed

Conversation

janmichek
Copy link
Collaborator

Description

resolves #462

I choose store solution rather than project the current state to url.

It resolved the annoying UX, but it's nothing advanced. As you see in the demo, the tx data is a snapshot from the initial access to the page. EG: You go 3 pages Next, you go 3 pages back (even tho there has been new transactions created).

Some advanced solution would require page index information from MDW. Currently, we count the page index on FE. So for the case going back from detail to listing, the app will lose information about the current page index.
I don't think such a solution is good.

I also recommend checking reference explorers, how they solve it. They have more simplistic solution

Demo

firefox_kEXrjsnl2M.mp4

Checklist:

@janmichek
Copy link
Collaborator Author

Created a new PR here. It has already been approved by LIubov and Denis here #603
Check the notes in there @michele-franchi

@janmichek janmichek closed this Jun 6, 2024
@janmichek
Copy link
Collaborator Author

The build stopped working. Let's continue in here #834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store transaction page/cursor in url of accounts page
1 participant