feat: Oracles details events tab 2 #196

janmichek · 2023-05-02T13:34:16Z

Description

resolves #16

followup #200

Demo

firefox_5BayglKkCB.mp4

Checklist:

I have read and followed the Contributing Guide

github-actions · 2023-05-02T13:39:01Z

Deployed to https://pr-196-aescan.stg.aepps.com

lukeromanowicz

Looks good, and works perfectly. The code is also almost flawless 👍

src/components/OracleEventsTable.vue

lukeromanowicz · 2023-05-04T07:24:56Z

One additional thing worth taking look at is the fee. In this example either the fee has been changed since the last query or we probably have wrong formatting on one of the values:
https://pr-196-aescan.stg.aepps.com/oracles/ok_qJZPXvWPC7G9kFVEqNjj9NAmwMsQcpRu6E3SSCvCQuwfqpMtN

lukeromanowicz

Nice, job well done :)

janmichek · 2023-05-04T09:08:34Z

One additional thing worth taking look at is the fee. In this example either the fee has been changed since the last query or we probably have wrong formatting on one of the values: https://pr-196-aescan.stg.aepps.com/oracles/ok_qJZPXvWPC7G9kFVEqNjj9NAmwMsQcpRu6E3SSCvCQuwfqpMtN

I discovered it's not a problem of formatting. Any ideas? SHould I consult with MDW team?

michele-franchi

Well, at the end we decided to display only responses and I see the code is still requesting queries.

I would instead use
https://mainnet.aeternity.io/mdw/v2/oracles/ok_qJZPXvWPC7G9kFVEqNjj9NAmwMsQcpRu6E3SSCvCQuwfqpMtN/responses endpoint which provides query and response data
Unfortunately it does not provide any information about block hash or micro time so we will have to remove "Queried At" and "Respond At". All the other data is available in the endpoint.

janmichek · 2023-05-08T09:05:31Z

@michele-franchi Ok, will do. This was my original solution .)

janmichek · 2023-05-08T13:05:37Z

@michele-franchi
There is a expand parameter for the oracle detail, which I think I should use

https://mainnet.aeternity.io/mdw/v2/oracles/ok_R7cQfVN15F5ek1wBSYaMRjW2XbMRKx7VDQQmbtwxspjZQvmPM?expand

Micro time and block height (I guess it's for response seems to be available)
QueryTx = register_tx_hash and ResponseTx = extends[index].hash ... correct?

janmichek · 2023-05-08T14:22:44Z

src/components/OracleEventsTable.vue

+              :is-collapsed="!isOpened.includes(index)"
+              @click="toggle(index)"/>
+          </td>
+          <td :class="[{'oracle-events-table__data--opened': isOpened.includes(index)}]">


This is for styling purposes of the last line, that should not be visible when details are open

janmichek · 2023-05-09T13:38:04Z

This was what confused me
5b86a63

michele-franchi

Please have a look at my comments.

I also noticed the following:

Pagination does not work
I get multiple errors in the console when I visit https://pr-196-aescan.stg.aepps.com/oracles/ok_Gb6cD91w29v8csjAxyyBmfAQmdNo1aUedWkhn9HxqiXeVuGcj

It does not fit well on mobile when the response is expanded:

src/components/OracleEventsQueryPanel.vue

michele-franchi · 2023-05-09T14:34:48Z

src/components/OracleEventsQueryPanel.vue

+      <dd>{{ formatAePrice(event.queryFee) }}</dd>
+
+      <dt> Query:</dt>
+      <dd> {{ event.query }}</dd>


This is a base64 and should be decoded.

michele-franchi · 2023-05-09T14:34:53Z

src/components/OracleEventsQueryPanel.vue

+      <dd>{{ event.responseTtl }}</dd>
+
+      <dt> Response:</dt>
+      <dd> {{ event.response }}</dd>


This is a base64 and should be decoded.

Interesting, the decode function is not working as expected. I will have to investigate.

src/components/OracleEventsQueryPanel.vue

janmichek · 2023-05-10T09:00:08Z

The pagination is hidden because there are not enough elements. Actually there is no single oracle that would have that many events ./

michele-franchi · 2023-05-10T09:05:41Z

@janmichek I see pagination here: https://pr-196-aescan.stg.aepps.com/oracles/ok_Gb6cD91w29v8csjAxyyBmfAQmdNo1aUedWkhn9HxqiXeVuGcj but It does not work.

janmichek · 2023-05-10T09:28:58Z

@michele-franchi Right, sorry my fault, I overlooked this. Now I think I made it working.

janmichek · 2023-05-10T13:31:55Z

All fixed now, also with the UX

firefox_4Q14YMzipz.mp4

janmichek · 2023-05-11T08:03:27Z

@janmichek the code works well but knowing that this middleware endpoint is highly susceptible to failures I think we should somehow handle this situation in the frontend, especially since we don't have a proper error 500 page yet.

Thanks for another round, just give it a green light .)

lukeromanowicz

Really nice, approving

michele-franchi

It still does not look right to me, for example when I visit https://pr-196-aescan.stg.aepps.com/oracles/ok_2fVpBb8j58mNQcVjY7bwUVpBWZv6AySGDjqepNofU8XGGmEN53 I get different errors:

I think it's because the oracle does not have responses and this should be handled somehow. Also I would suggest to check with middleware why the endpoint is returning 500.

janmichek · 2023-05-11T11:24:54Z

It still does not look right to me, for example when I visit https://pr-196-aescan.stg.aepps.com/oracles/ok_2fVpBb8j58mNQcVjY7bwUVpBWZv6AySGDjqepNofU8XGGmEN53 I get different errors:

I think it's because the oracle does not have responses and this should be handled somehow. Also I would suggest to check with middleware why the endpoint is returning 500.

Found out this is a MDW issue aeternity/ae_mdw#1307 Not sure, how should we proceed @michele-franchi

michele-franchi · 2023-05-12T07:24:36Z

It still does not look right to me, for example when I visit https://pr-196-aescan.stg.aepps.com/oracles/ok_2fVpBb8j58mNQcVjY7bwUVpBWZv6AySGDjqepNofU8XGGmEN53 I get different errors:

I think it's because the oracle does not have responses and this should be handled somehow. Also I would suggest to check with middleware why the endpoint is returning 500.

Found out this is a MDW issue aeternity/ae_mdw#1307 Not sure, how should we proceed @michele-franchi

@janmichek
Even if it's a mdw issue this should be handled somehow, I don't expect to see the following if an API endpoint fails:

I'm not even talking from a UI perspective, I know we should handle errors properly but I don't expect the code to break.

janmichek · 2023-05-15T08:54:07Z

@michele-franchi Ok, got it. I created a predecessor of the proper solution #95 just for this entity, so we can reuse my solution later

firefox_H0DIgHlZ7x.mp4

michele-franchi

It still does not work, could you check again?

I see you implemented a way to handle errors from a UI perspective but in my last comment I simply suggested to handle errors from a code perspective.
Right now the code breaks and it executes slice on undefined. The simple solution would simply have been to not let the code break (avoid slice on undefined) as handling errors from a UI perspective is a wider topic but we can leave it like it is but please check the code 😄

janmichek · 2023-05-16T07:52:23Z

ou implemented a way to hand

That's another problem presented already in develop, not related to this implementation. I tried to discuss it here. How should we sanitize it? #222

michele-franchi

It looks good now, let's also have a look at the bug 😄

Good job!

janmichek · 2023-05-16T08:36:32Z

It looks good now, let's also have a look at the bug 😄

Good job!

I will solve it separately right after. I will also verify with MDW

add orecleEvents UI

6e937f8

janmichek changed the title ~~add orecleEvents UI~~ feat: Oracles details events tab 2 May 2, 2023

janmichek mentioned this pull request May 2, 2023

feat: Oracles details events tab #175

Closed

1 task

janmichek added 11 commits May 2, 2023 16:29

add response button ui

a7c1077

add pagination

5e0b593

add query panel to condensed view

49f7291

add button icons

e63c2fb

fix conditional styling of table rows

bf3880f

replace missing walues with placeholder

08f10b8

code cleanup

2f06129

adjust query response

dcc8130

add scoped style

b3584b2

remove console.log

4834bbc

fix css order

de0dea5

janmichek requested review from michele-franchi and lukeromanowicz May 3, 2023 18:29

lukeromanowicz suggested changes May 4, 2023

View reviewed changes

src/components/OracleEventsTable.vue Show resolved Hide resolved

src/components/OracleEventsTable.vue Outdated Show resolved Hide resolved

janmichek added 2 commits May 4, 2023 10:45

fix table markup

c47bfa8

remove unneccessary prop

2d7925f

lukeromanowicz approved these changes May 4, 2023

View reviewed changes

prop fixes

9f88ae8

michele-franchi requested changes May 8, 2023

View reviewed changes

janmichek added 2 commits May 8, 2023 16:07

rewire UI to oracle endpoint

9a86e5e

rename classname

3c3ac2a

janmichek commented May 8, 2023

View reviewed changes

michele-franchi requested changes May 9, 2023

View reviewed changes

janmichek added 4 commits May 10, 2023 10:13

fix typo

301e752

remove unnecessary styling

9085533

remove unused prop

dcb3b40

revert async data fetching

c5f9b73

janmichek added 2 commits May 10, 2023 11:11

fix printing query and response

912a67f

fix pagination

d4138de

janmichek requested a review from michele-franchi May 10, 2023 13:33

janmichek and others added 3 commits May 10, 2023 15:35

fix pagination UX

e23c398

change pagination label style

7d8782f

Merge branch 'develop' into Oracles_details_events_tab_2

8fb54d4

lukeromanowicz approved these changes May 11, 2023

View reviewed changes

michele-franchi requested changes May 11, 2023

View reviewed changes

sanitize failed data fetching

e453fa5

janmichek requested a review from michele-franchi May 15, 2023 08:54

michele-franchi requested changes May 16, 2023

View reviewed changes

michele-franchi approved these changes May 16, 2023

View reviewed changes

janmichek merged commit c1cd7bb into develop May 16, 2023

janmichek deleted the Oracles_details_events_tab_2 branch May 16, 2023 08:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Oracles details events tab 2 #196

feat: Oracles details events tab 2 #196

janmichek commented May 2, 2023 •

edited

Loading

github-actions bot commented May 2, 2023

lukeromanowicz left a comment

lukeromanowicz commented May 4, 2023

lukeromanowicz left a comment

janmichek commented May 4, 2023

michele-franchi left a comment

janmichek commented May 8, 2023

janmichek commented May 8, 2023

janmichek May 8, 2023

janmichek commented May 9, 2023

michele-franchi left a comment

michele-franchi May 9, 2023

janmichek May 10, 2023

michele-franchi May 9, 2023

janmichek May 10, 2023

janmichek commented May 10, 2023

michele-franchi commented May 10, 2023 •

edited

Loading

janmichek commented May 10, 2023

janmichek commented May 10, 2023

janmichek commented May 11, 2023

lukeromanowicz left a comment

michele-franchi left a comment

janmichek commented May 11, 2023

michele-franchi commented May 12, 2023 •

edited

Loading

janmichek commented May 15, 2023

michele-franchi left a comment •

edited

Loading

janmichek commented May 16, 2023

michele-franchi left a comment

janmichek commented May 16, 2023

feat: Oracles details events tab 2 #196

feat: Oracles details events tab 2 #196

Conversation

janmichek commented May 2, 2023 • edited Loading

Description

Demo

Checklist:

github-actions bot commented May 2, 2023

lukeromanowicz left a comment

Choose a reason for hiding this comment

lukeromanowicz commented May 4, 2023

lukeromanowicz left a comment

Choose a reason for hiding this comment

janmichek commented May 4, 2023

michele-franchi left a comment

Choose a reason for hiding this comment

janmichek commented May 8, 2023

janmichek commented May 8, 2023

janmichek May 8, 2023

Choose a reason for hiding this comment

janmichek commented May 9, 2023

michele-franchi left a comment

Choose a reason for hiding this comment

michele-franchi May 9, 2023

Choose a reason for hiding this comment

janmichek May 10, 2023

Choose a reason for hiding this comment

michele-franchi May 9, 2023

Choose a reason for hiding this comment

janmichek May 10, 2023

Choose a reason for hiding this comment

janmichek commented May 10, 2023

michele-franchi commented May 10, 2023 • edited Loading

janmichek commented May 10, 2023

janmichek commented May 10, 2023

janmichek commented May 11, 2023

lukeromanowicz left a comment

Choose a reason for hiding this comment

michele-franchi left a comment

Choose a reason for hiding this comment

janmichek commented May 11, 2023

michele-franchi commented May 12, 2023 • edited Loading

janmichek commented May 15, 2023

michele-franchi left a comment • edited Loading

Choose a reason for hiding this comment

janmichek commented May 16, 2023

michele-franchi left a comment

Choose a reason for hiding this comment

janmichek commented May 16, 2023

janmichek commented May 2, 2023 •

edited

Loading

michele-franchi commented May 10, 2023 •

edited

Loading

michele-franchi commented May 12, 2023 •

edited

Loading

michele-franchi left a comment •

edited

Loading