feat: Loading for tables #419
Conversation
|
Deployed to https://pr-419-aescan.stg.aepps.com |
|
If you don't mind I'll review it once panel loading indicators are done since there is far less changes |
janmichek
force-pushed
the
Loading-indicator-for-tables
branch
from
69cf1ec to
8e34f1a
Compare
I don't think this dependency is needed. Can be reviewed independently |
There was a problem hiding this comment.
This is working very nicely and apart from a minor refactoring proposition I'd accept it. My question is wether this is a concept showcase that will be applied to the remaining tables such as:
2023-08-08.09-54-28.mp4
or are you finished? In the second case I would add it in the other tables too :)
| } | ||
|
|
||
| const paginatedContent = ref() | ||
| watch( |
There was a problem hiding this comment.
I think we should make a dedicated composable e.g. useTableLoadingIndicator for that because this will be reused in most of the pages containing tables
There was a problem hiding this comment.
I think now when I fixed the resetting it's not an issue anymore.
The pagination for tables is only handled by PaginatedContent component, right?
If I missed your point, please give me some examples of which other table would you reuse it?
There was a problem hiding this comment.
I misinterpreted the code. Please ignore it
You are right, I forgot to reset the store before navigating. Fixed |
There was a problem hiding this comment.
I found some issues during testing, could you please have a look at them?
- Table content changes width when switching tabs
- 500 error on page reload
Screen.Recording.2023-08-08.at.23.57.02.mov
- Oracles events does not display the loader
I will review again once fixed.
Thanks for the detailed check. All fixed. It produced one more conflict, I would better resolve in here |
SHould I set some followup issue? What you desire to improve? |
| } | ||
|
|
||
| const paginatedContent = ref() | ||
| watch( |
There was a problem hiding this comment.
I misinterpreted the code. Please ignore it
|
LGTM |
Description
fixes #150
Loader style will be improved once delivered from Danilo
Demo
firefox_KnfzPwFNVM.mp4
Checklist: