-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show hint if AENS name is in revoked state 2 #609
Conversation
Deployed to https://pr-609-aescan.stg.service.aepps.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I click on Next button to see other expires names the page becomes uploading status forever. The same issue is on product.
2023-12-11.4.42.00.mov
I found additional issue on product, when I click on next button to see other In-auction names the previous button becomes unavailable. But maybe this is middleware issue?
if not, I will register it separately.
2023-12-11.4.46.37.mov
@janmichek please check it.
Hmm, interesting. I tried the same scenario without any probs. Maye there was some server downtime at that moment? Can I ask you to try again today?
Yes, I confirm this issue. WIll solve it separately. Good finding, thanks |
@janmichek I have a question: I can see some names in both tabs - Expired and In Auction, for example 77.chain and public.chain. Is this expected? |
2023-12-12.5.05.14.mov |
Thanks, should not be like that. I will check and possibly fix |
Followup #621 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except the issues that I found and they should be fixed separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description
resolves #454
Demo
firefox_51Lk8cgK46.mp4
Checklist: