-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Names charts #641
feat: Names charts #641
Conversation
Deployed to https://pr-641-aescan.stg.service.aepps.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM.
But is this correct aligning?
https://github.com/aeternity/aescan/assets/69896204/5f3f322c-0e4a-4b76-bdec-79966d3488ab
Yeah, that's what is the data. I can do better with printing the labels for Y axis. There should be only full numbers, no fractions. |
I found that for some dates it will not shown any data, just red dot: 2024-01-08.6.00.55.mov@janmichek please check it |
Good catch, fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove some dev lines and it will look good! I approve in advance.
src/stores/names.js
Outdated
// async function fetchNamesStatistics(slug) { | ||
// namesStatistics.value = null | ||
// const { data } = await axios.get(`${MIDDLEWARE_URL}/v3/statistics/names${slug || '?limit=8&interval_by=day'}`) | ||
// namesStatistics.value = data.data.reverse() | ||
// // namesStatistics.value = data.data.slice(1).reverse() | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this commented function useful or can it be removed?
src/stores/oracleDetails.js
Outdated
@@ -40,11 +40,13 @@ export const useOracleDetailsStore = defineStore('oracleDetails', () => { | |||
async function fetchOracle() { | |||
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/oracles/${oracleId.value}?tx_hash=true`) | |||
rawOracle.value = data | |||
console.log('1 rawOracle.value', rawOracle.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log('1 rawOracle.value', rawOracle.value) |
src/stores/oracleDetails.js
Outdated
} | ||
|
||
async function fetchLastExtendedTx() { | ||
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/txs?direction=backward&limit=1&type=oracle_extend&oracle=${oracleId.value}`) | ||
lastExtendedTx.value = data.data?.[0] | ||
console.log('3 lastExtendedTx.value', lastExtendedTx.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log('3 lastExtendedTx.value', lastExtendedTx.value) |
src/stores/oracleDetails.js
Outdated
@@ -57,6 +59,7 @@ export const useOracleDetailsStore = defineStore('oracleDetails', () => { | |||
} catch (e) { | |||
rawEvents.value = null | |||
} | |||
console.log('2 rawEvents.value', rawEvents.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log('2 rawEvents.value', rawEvents.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, my bad. All dev code removed
Description
resolves #533
Demo
Checklist: