Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Names charts #641

Merged
merged 7 commits into from
Jan 10, 2024
Merged

feat: Names charts #641

merged 7 commits into from
Jan 10, 2024

Conversation

janmichek
Copy link
Collaborator

Description

resolves #533

Demo

Checklist:

@janmichek janmichek changed the title Names charts feat: Names charts Jan 3, 2024
Copy link

github-actions bot commented Jan 3, 2024

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek
Copy link
Collaborator Author

In general LGTM. But is this correct aligning? https://github.com/aeternity/aescan/assets/69896204/5f3f322c-0e4a-4b76-bdec-79966d3488ab

Yeah, that's what is the data. I can do better with printing the labels for Y axis. There should be only full numbers, no fractions.

@janmichek
Copy link
Collaborator Author

At least I fixed it in this fashion
image
Not super satisfied about it, but that's the data we get. We can consult if you guys have some bright ideas .)

@Liubov-crypto
Copy link
Collaborator

I found that for some dates it will not shown any data, just red dot:
tr

2024-01-08.6.00.55.mov

@janmichek please check it

@janmichek
Copy link
Collaborator Author

I found that for some dates it will not shown any data, just red dot: tr
2024-01-08.6.00.55.mov

@janmichek please check it

Good catch, fixed it.

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, LGTM.

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove some dev lines and it will look good! I approve in advance.

Comment on lines 77 to 82
// async function fetchNamesStatistics(slug) {
// namesStatistics.value = null
// const { data } = await axios.get(`${MIDDLEWARE_URL}/v3/statistics/names${slug || '?limit=8&interval_by=day'}`)
// namesStatistics.value = data.data.reverse()
// // namesStatistics.value = data.data.slice(1).reverse()
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented function useful or can it be removed?

@@ -40,11 +40,13 @@ export const useOracleDetailsStore = defineStore('oracleDetails', () => {
async function fetchOracle() {
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/oracles/${oracleId.value}?tx_hash=true`)
rawOracle.value = data
console.log('1 rawOracle.value', rawOracle.value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('1 rawOracle.value', rawOracle.value)

}

async function fetchLastExtendedTx() {
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/txs?direction=backward&limit=1&type=oracle_extend&oracle=${oracleId.value}`)
lastExtendedTx.value = data.data?.[0]
console.log('3 lastExtendedTx.value', lastExtendedTx.value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('3 lastExtendedTx.value', lastExtendedTx.value)

@@ -57,6 +59,7 @@ export const useOracleDetailsStore = defineStore('oracleDetails', () => {
} catch (e) {
rawEvents.value = null
}
console.log('2 rawEvents.value', rawEvents.value)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('2 rawEvents.value', rawEvents.value)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, my bad. All dev code removed

@janmichek janmichek merged commit e7350de into develop Jan 10, 2024
2 checks passed
@janmichek janmichek deleted the Names-charts branch January 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names charts
3 participants