Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: If user look at the activity of the selected account, then in the third step the view will break #672

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Mar 5, 2024

Description

fixes #628
related #362

Demo

firefox_MrBz7V3U4d.mp4

Checklist:

  • I have read and followed the Contributing Guide
  • add aex141 transfer event activity component

Copy link

github-actions bot commented Mar 5, 2024

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be fixed on testnet, but mainnet isn't working for me. I got 404 error in Chrome and Firefox.

@janmichek please check it.

@janmichek
Copy link
Collaborator Author

It seems to be fixed on testnet, but mainnet isn't working for me. I got 404 error in Chrome and Firefox.

@janmichek please check it.

Stange, I can access both deployments.

@janmichek
Copy link
Collaborator Author

I am not

It seems to be fixed on testnet, but mainnet isn't working for me. I got 404 error in Chrome and Firefox.

@janmichek please check it.

I am consulting this infrastructure issue with Petar, it's not super reliable for sure.

@janmichek janmichek requested a review from Liubov-crypto March 7, 2024 04:47
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, LGTM

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the recipient address instead of the AEX-141 smart contract.

Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@janmichek janmichek merged commit 72e2176 into develop Mar 12, 2024
1 of 3 checks passed
@janmichek janmichek deleted the If-user-look-at-the-activity-of-the-selected-account,-then-in-the-third-step-the-view-will-break branch March 12, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If user look at the activity of the selected account, then in the third step the view will break
3 participants