Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: internal Chain.spend values #700

Merged
merged 2 commits into from
Mar 26, 2024
Merged

feat: internal Chain.spend values #700

merged 2 commits into from
Mar 26, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Mar 25, 2024 •
edited
Loading

Description

resolves #699

Demo

image

Checklist:

  • I have read and followed the Contributing Guide
  • display price value for internal Chain.spend

@github-actions GitHub Actions
Copy link

Deployed to https://pr-700-aescan.stg.service.aepps.com and https://pr-700-aescan-testnet.stg.service.aepps.com

@janmichek janmichek requested a review from Liubov-crypto March 25, 2024 08:08
@janmichek janmichek mentioned this pull request Mar 25, 2024
Closed
2 tasks
@thepiwo
Copy link
Collaborator

thepiwo commented Mar 25, 2024

Could we also show the function name of the internal call, e.g. Chain.spend?

@janmichek
Copy link
Collaborator Author

Could we also show the function name of the internal call, e.g. Chain.spend?

It's already there @thepiwo https://pr-700-aescan.stg.service.aepps.com/accounts/ak_MAp9r1m6jP7P7ncexacy7VTtjCcDJufqPY4cn5QwtmEKf6N7U?type=activities

Liubov-crypto
Liubov-crypto reviewed Mar 25, 2024
View reviewed changes
Copy link

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is this expected view?

trs

@janmichek
Copy link
Collaborator Author

LGTM.

Is this expected view?

trs

Yeah I think so. What is the address so I can verify It?

michele-franchi
michele-franchi approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great

@janmichek janmichek merged commit 0b20a49 into develop Mar 26, 2024
3 of 4 checks passed
@janmichek janmichek deleted the internal-Chain.spend-values branch March 26, 2024 09:31
@aeternity-bot aeternity-bot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto left review comments

@thepiwo thepiwo thepiwo approved these changes

@michele-franchi michele-franchi michele-franchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal Chain.spend values
4 participants
@janmichek @thepiwo @michele-franchi @Liubov-crypto