Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Name fee is empty #729

Merged
merged 2 commits into from
Apr 25, 2024
Merged

fix: Name fee is empty #729

merged 2 commits into from
Apr 25, 2024

Conversation

janmichek
Copy link
Collaborator

Description

resolves #727

Not sure why it stopped working now. I believe all was working before, there has not been any change in files for a year.

Demo

firefox_fOSmGX2xk4.mp4

Checklist:

Copy link

@michele-franchi
Copy link
Collaborator

@janmichek to me it sounds something got removed from the mdw endpoint so I would first investigate that with them also to understand if fee / name fee are equal.

@janmichek
Copy link
Collaborator Author

@janmichek to me it sounds something got removed from the mdw endpoint so I would first investigate that with them also to understand if fee / name fee are equal.

Question raised here https://aeternity-workspace.slack.com/archives/C04K21DM61L/p1713356209778889

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@michele-franchi
Copy link
Collaborator

@janmichek solution: the fee box should be hidden if nameFee is not available

@janmichek
Copy link
Collaborator Author

@janmichek solution: the fee box should be hidden if nameFee is not available

fixed

@janmichek janmichek requested a review from Liubov-crypto April 23, 2024 03:32
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michele-franchi michele-franchi merged commit a5ee669 into develop Apr 25, 2024
3 checks passed
@michele-franchi michele-franchi deleted the Name-fee-is-empty branch April 25, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name fee is empty
3 participants