Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display all testnet tokens #739

Closed
wants to merge 14 commits into from
Closed

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Apr 24, 2024

Description

resolves #732

Demo

image

image

Checklist:

  • I have read and followed the Contributing Guide
  • disable listed tokens for testnet
  • add N/A labels

Copy link

@janmichek
Copy link
Collaborator Author

as folowup I created this #742

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an issue, total supply is missing for some tokens:

comm

2024-04-25.1.12.11.mov

I can't see holders, probably some issues with backend:

backend

@janmichek
Copy link
Collaborator Author

@Liubov-crypto all fixed, thanks for testing

@janmichek janmichek requested a review from Liubov-crypto April 30, 2024 05:46
@Liubov-crypto
Copy link
Collaborator

I have a question: is total supply and Amount of the tokens held by its owner shouldn't be the same?
https://github.com/aeternity/aescan/assets/69896204/f5f977a9-79fd-416e-bff7-a75ce9402873

if the one account is holding all amount of tokens, then percentage field should be 100%?

2024-04-30.3.19.57.mov

for example I can see Percentage on mainnet:

2024-04-30.3.24.15.mov

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janmichek please check it

@michele-franchi
Copy link
Collaborator

I have a question: is total supply and Amount of the tokens held by its owner shouldn't be the same? https://github.com/aeternity/aescan/assets/69896204/f5f977a9-79fd-416e-bff7-a75ce9402873

if the one account is holding all amount of tokens, then percentage field should be 100%?

2024-04-30.3.19.57.mov
for example I can see Percentage on mainnet:

2024-04-30.3.24.15.mov

@janmichek did you already fix this issue?

@janmichek
Copy link
Collaborator Author

I have a question: is total supply and Amount of the tokens held by its owner shouldn't be the same? https://github.com/aeternity/aescan/assets/69896204/f5f977a9-79fd-416e-bff7-a75ce9402873
if the one account is holding all amount of tokens, then percentage field should be 100%?
2024-04-30.3.19.57.mov
for example I can see Percentage on mainnet:
2024-04-30.3.24.15.mov

@janmichek did you already fix this issue?

Nope, there is some delicate bug :D it appears on PR preview, but works on localhost.

@janmichek
Copy link
Collaborator Author

Can we continue on the review here? #783 I could not make it right here

@janmichek janmichek closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display all testnet tokens
3 participants