Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Raw data pointer support for Ceres #761

Merged
merged 8 commits into from
May 17, 2024

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented May 8, 2024

Copy link

github-actions bot commented May 8, 2024

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got some issue when tried to check info about name that is in auction:

2024-05-14.5.01.35.mov

au1

@janmichek please check it

@janmichek janmichek force-pushed the Raw-data-pointer-support-for-Ceres branch from 1110c79 to a1dc13d Compare May 15, 2024 08:54
@janmichek janmichek requested a review from Liubov-crypto May 15, 2024 11:04
@janmichek
Copy link
Collaborator Author

I got some issue when tried to check info about name that is in auction:
2024-05-14.5.01.35.mov

au1

@janmichek please check it

Good catch, it's fixed now

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to remove some console.log @janmichek.

src/utils/adapters.js Outdated Show resolved Hide resolved
src/utils/adapters.js Outdated Show resolved Hide resolved
@janmichek janmichek requested a review from michele-franchi May 16, 2024 12:13
@janmichek
Copy link
Collaborator Author

@michele-franchi fixed, can you check again, please?

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michele-franchi michele-franchi merged commit 5190403 into develop May 17, 2024
3 checks passed
@michele-franchi michele-franchi deleted the Raw-data-pointer-support-for-Ceres branch May 17, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw data pointer support for Ceres
3 participants