Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider JS optimizations suggested by Lighthouse #801

Merged

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented May 22, 2024

Description

fixes #775

Demo

This issue was more of exploration of the topic what we can do in regards of optimization nut I was able to increase the score.
I implemented the nuxt-booster which is doing som lazy loading under the hood.
I also optimized the SVG icons.
There is more potential to optimize (listing for further improvements)

  • off load from Main thread (using nuxt booster or partytown) (Sentry, plausible)
  • lazy load, off load or replace monaco editor as it is a biggest dependency
  • creating dedicated backend will also help to reduce waiting time as there is a lot of data gluing

Anyway this attempt helped to increase the score
You can compare the result with some other PR without optimization
https://pagespeed.web.dev/analysis/https-pr-811-aescan-stg-service-aepps-com/3ko3nump6i?form_factor=mobile
https://pagespeed.web.dev/analysis/https-pr-801-aescan-stg-service-aepps-com/lb66xs5x03?form_factor=mobile

I also tested with Unlighthous which crawls more pages than just mainpage

image
image

Checklist:

Copy link

@janmichek janmichek force-pushed the Consider-JS-optimizations-suggested-by-Lighthouse branch from 95099fd to 87df74e Compare May 23, 2024 09:16
@janmichek janmichek force-pushed the Consider-JS-optimizations-suggested-by-Lighthouse branch 2 times, most recently from 88c918f to 8bd6edc Compare May 27, 2024 11:28
@michele-franchi michele-franchi removed the request for review from lukeromanowicz May 31, 2024 09:50
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janmichek janmichek requested a review from Liubov-crypto June 5, 2024 09:15
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janmichek janmichek merged commit 8f8e1ac into develop Jun 5, 2024
5 checks passed
@janmichek janmichek deleted the Consider-JS-optimizations-suggested-by-Lighthouse branch June 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider JS optimizations suggested by Lighthouse
3 participants