-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Consider JS optimizations suggested by Lighthouse #801
Merged
janmichek
merged 8 commits into
develop
from
Consider-JS-optimizations-suggested-by-Lighthouse
Jun 5, 2024
Merged
fix: Consider JS optimizations suggested by Lighthouse #801
janmichek
merged 8 commits into
develop
from
Consider-JS-optimizations-suggested-by-Lighthouse
Jun 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmichek
force-pushed
the
Consider-JS-optimizations-suggested-by-Lighthouse
branch
from
May 23, 2024 09:16
95099fd
to
87df74e
Compare
janmichek
force-pushed
the
Consider-JS-optimizations-suggested-by-Lighthouse
branch
2 times, most recently
from
May 27, 2024 11:28
88c918f
to
8bd6edc
Compare
michele-franchi
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Liubov-crypto
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #775
Demo
This issue was more of exploration of the topic what we can do in regards of optimization nut I was able to increase the score.
I implemented the nuxt-booster which is doing som lazy loading under the hood.
I also optimized the SVG icons.
There is more potential to optimize (listing for further improvements)
Anyway this attempt helped to increase the score
You can compare the result with some other PR without optimization
https://pagespeed.web.dev/analysis/https-pr-811-aescan-stg-service-aepps-com/3ko3nump6i?form_factor=mobile
https://pagespeed.web.dev/analysis/https-pr-801-aescan-stg-service-aepps-com/lb66xs5x03?form_factor=mobile
I also tested with Unlighthous which crawls more pages than just mainpage
Checklist: