Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin encoding into aeser #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Pin encoding into aeser #24

wants to merge 6 commits into from

Conversation

klercker
Copy link

Moved the pin encoding/decoding methods from core to serialization. A follow-up PR will be done post merge for the corresponding refactoring in aeternity/aeternity

This pull request is supported by the Æternity Foundation.

Copy link
Member

@hanssv hanssv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this to aeserialization is 100% the right move 👍

But, I would like this to be less prominent, i.e. in a separarte module. And it should be made much more clear that this is HyperChains stuff!

@klercker
Copy link
Author

So, proposing to do this:

  1. introduce aeser_hc.erlmodule
  2. Move the methods there
    ...and then we have ourselves a merry little Christmas 🎄 (in a week of course...)

hanssv
hanssv previously approved these changes Dec 13, 2024
src/aeser_hc.erl Outdated Show resolved Hide resolved
hanssv
hanssv previously approved these changes Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants