Pin Reward Config and Carry-over #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanssv
reviewed
Nov 4, 2024
klercker
force-pushed
the
reward_config_carry
branch
from
dd0ae23 to
558f172
Compare
|
pin reward now moved from epoch to state in HCElection.aes (and other relevant places). Also fixed staking contract test. |
hanssv
approved these changes
Nov 6, 2024
|
@hanssv thanks for the approval, for some reason I did not see comments and updates on the PR. I will keep things as they are and address your comments in a future commit/PR (as they all are good points). |
happi
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
#4469
This PR is supported by the Aeternity Foundation