Skip to content

Commit

Permalink
refactor(AboutModel): get sdk version from package.json
Browse files Browse the repository at this point in the history
  • Loading branch information
bogdan-manole authored and kenodressel committed Feb 14, 2024
1 parent c16cfb3 commit dcd8173
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"lint": "npm run lint:script && npm run lint:style"
},
"dependencies": {
"@aeternity/aepp-sdk": "^13.2.2",
"@aeternity/aepp-sdk": "13.2.2",
"@fontsource/ibm-plex-sans": "^4.5.11",
"@popperjs/core": "^2.11.5",
"@sentry/tracing": "^7.8.1",
Expand Down
9 changes: 1 addition & 8 deletions src/components/AboutModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,6 @@
:right-text="activeNetwork.dexBackendUrl"
/>
</template>
<InfoRow
:left-text="$t('aboutModal.compiler')"
:right-text="compilerUrl"
/>
<InfoRow
:left-text="$t('aboutModal.node')"
:right-text="nodeVersion"
Expand All @@ -54,8 +50,6 @@
<script>
import { mapState, mapGetters } from 'vuex';
import contractInfo from 'dex-contracts-v2/package.json';
// TODO: i don't think this is ok
import packageLock from '../../package-lock.json';
import ModalDefault from './ModalDefault.vue';
import appInfo from '../../package.json';
import InfoRow from './InfoRow.vue';
Expand All @@ -71,9 +65,8 @@ export default {
},
data: () => ({
appVersion: appInfo.version,
sdkVersion: packageLock.packages['node_modules/@aeternity/aepp-sdk'].version,
sdkVersion: appInfo.dependencies['@aeternity/aepp-sdk'],
contractsVersion: contractInfo.version,
compilerUrl: process.env.VUE_APP_COMPILER_URL,
height: null,
nodeVersion: null,
pollHeight: null,
Expand Down

0 comments on commit dcd8173

Please sign in to comment.