sdk update

[bogdan-manole]

fixes #357

temp todo list:

• browser wallet connection
• mobile wallet connection
• on user rejection or when first wallet connect there is a general error

[github-actions]

Deployed to https://pr-497-dex-ui.stg.aepps.com

[thepiwo]

what is still needed here?

[thepiwo]

why shouldn't it be?

[davidyuk]

I think because package-lock is 1.52 MB. I'm not sure about the best practice here.

Should I add "package.json" to "exports" field of aepp-sdk? Or to export sdk version as a constant? I think the best would be to have a solution that works the same for any npm dependency.

As a workaround, you can import the local package.json but there would be a lower-bound version of the installed sdk.

On the other side, you don't need the whole package.json, just a single field of it, maybe you can retrive it in vue.config.js and copy it to a global definition? Then there would be no extra data in the bundle.

dex-ui/vue.config.js

Line 11 in 6895935

definitions['process.env.UNFINISHED_FEATURES'] = parseBool(process.env.VUE_APP_UNFINISHED_FEATURES);

[thepiwo]

Yes, but using the package.json should be fine

[davidyuk]

Suggested change

	this.nodeVersion = (await this.sdk.getNodesInPool()).find((node) => node.name
	=== this.sdk.selectedNodeName)?.version || '-';
	try {
	this.nodeVersion = await this.sdk.api.getNetworkId();
	} catch (e) {
	this.nodeVersion = '-';
	}

Or maybe you don't need try/catch if you have some node by default.

[bogdan-manole]

but this is about the node version, not the networkId

[davidyuk]

my bad, proposing to use getNodeInfo instead of getting node info of all nodes

Suggested change

	this.nodeVersion = (await this.sdk.getNodesInPool()).find((node) => node.name
	=== this.sdk.selectedNodeName)?.version || '-';
	try {
	this.nodeVersion = (await this.sdk.api.getNodeInfo()).version;
	} catch (e) {
	this.nodeVersion = '-';
	}

[thepiwo]

Yes, but using the package.json should be fine