Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: global error handler, ErrorReportModal #1027

Closed
wants to merge 6 commits into from
Closed

feat: global error handler, ErrorReportModal #1027

wants to merge 6 commits into from

Conversation

shapkarin
Copy link
Contributor

@shapkarin shapkarin commented Mar 3, 2021 •
edited
Loading

This PR includes:

  • throw as much errors as possible instead of console logs
  • error popup for all unhandled exceptions with it's trace stack that showed one by one
    • if one is closed and there is one more error the new one appears

@shapkarin shapkarin requested a review from davidyuk March 3, 2021 15:14
@shapkarin
Copy link
Contributor Author

@davidyuk I also remove all about old maintenance logic and backendLive state itself, please notice if I'm doing wrong.

@shapkarin shapkarin force-pushed the feature/maintance_handler branch from 651dddf to f53ee0e Compare March 3, 2021 19:20
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

Deployed to feature-maintance-handler.aggregator.z52da5wt.xyz, bundle report

@shapkarin
Copy link
Contributor Author

@davidyuk I will recheck my work and ping you

davidyuk
davidyuk reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@davidyuk davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, write more accurate, ensure that it looks fine before asking for a review

src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
@shapkarin shapkarin force-pushed the feature/maintance_handler branch from 10fdc1a to 31067f9 Compare March 11, 2021 10:23
@shapkarin shapkarin requested a review from davidyuk March 11, 2021 10:25
@shapkarin
Copy link
Contributor Author

@davidyuk thanks for the conversation I will move error handler to the Vue plugin and refact some. Will ping you soon.

davidyuk
davidyuk requested changes Mar 15, 2021
View reviewed changes
Copy link
Member

@davidyuk davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all issues of the previous review are resolved

src/store/modules/aeternity.js Outdated Show resolved Hide resolved
src/styles/_fonts.scss Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
src/utils/index.js Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/assets/APIError.svg Outdated Show resolved Hide resolved
@shapkarin shapkarin force-pushed the feature/maintance_handler branch 3 times, most recently from c2e567e to c4bc9ad Compare March 16, 2021 07:00
@shapkarin shapkarin requested a review from davidyuk March 16, 2021 07:01
@shapkarin shapkarin force-pushed the feature/maintance_handler branch from e2cf062 to a7915e2 Compare March 16, 2021 10:15
@shapkarin shapkarin requested review from davidyuk and removed request for davidyuk March 16, 2021 10:22
davidyuk
davidyuk reviewed Mar 16, 2021
View reviewed changes
src/components/Button.vue Outdated Show resolved Hide resolved
@mradkov mradkov requested a review from davidyuk March 17, 2021 09:39
@shapkarin shapkarin force-pushed the feature/maintance_handler branch 3 times, most recently from ebd5eb8 to 8336079 Compare March 17, 2021 15:51
davidyuk
davidyuk reviewed Mar 18, 2021
View reviewed changes
Copy link
Member

@davidyuk davidyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you still didn't rebase it?

src/store/plugins/errorHandler.js Outdated Show resolved Hide resolved
src/store/plugins/errorHandler.js Outdated Show resolved Hide resolved
src/store/plugins/errorHandler.js Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/assets/iconEye.svg Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/components/ErrorModal.vue Outdated Show resolved Hide resolved
src/utils/backend.js Outdated Show resolved Hide resolved
@shapkarin shapkarin force-pushed the feature/maintance_handler branch 6 times, most recently from 8336079 to fe9707c Compare March 19, 2021 12:38
@github-actions
Copy link

SSR will be deployed to superhero.aeternity.io, bundle report

@stale stale bot added the stale label Aug 31, 2021
@aeternity aeternity deleted a comment from stale bot Aug 31, 2021
@stale stale bot removed the stale label Aug 31, 2021
@stale stale bot added the stale label Sep 7, 2021
@aeternity aeternity deleted a comment from stale bot Sep 7, 2021
@stale stale bot removed the stale label Sep 7, 2021
@CedrikNikita CedrikNikita force-pushed the feature/maintance_handler branch from 1a66e2e to e069742 Compare September 11, 2021 03:02
@stale stale bot added the stale label Sep 18, 2021
@stale stale bot closed this Sep 21, 2021
@aeternity aeternity deleted a comment from stale bot Sep 21, 2021
@CedrikNikita CedrikNikita reopened this Sep 21, 2021
@stale stale bot removed the stale label Sep 21, 2021
@stale stale bot added the stale label Sep 28, 2021
@aeternity aeternity deleted a comment from stale bot Sep 29, 2021
@stale stale bot removed the stale label Sep 29, 2021
@stale stale bot added the stale label Oct 6, 2021
@aeternity aeternity deleted a comment from stale bot Oct 8, 2021
@stale stale bot removed the stale label Oct 8, 2021
@stale
Copy link

stale bot commented Oct 15, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2021
@stale stale bot closed this Oct 18, 2021
@davidyuk davidyuk mentioned this pull request Dec 21, 2021
Open
@CedrikNikita CedrikNikita deleted the feature/maintance_handler branch February 22, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto left review comments

@onvisions onvisions onvisions left review comments

@thepiwo thepiwo thepiwo left review comments

@AtanasKrondev AtanasKrondev AtanasKrondev approved these changes

@mradkov mradkov Awaiting requested review from mradkov

@davidyuk davidyuk Awaiting requested review from davidyuk

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shapkarin @Liubov-crypto @davidyuk @thepiwo @onvisions @AtanasKrondev @CedrikNikita