Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sub-element bug and dry internal handling of options #58

Conversation

fledman
Copy link
Contributor

@fledman fledman commented Sep 20, 2018

in current master:

  1. the[]= syntax does not properly update @sub_elements
  2. the first call of the .= syntax does not properly update @sub_elements
  3. every time you want to add a new option, you need to adjust each self.class.new callsite to pass the new option along recursively

this PR:

  1. fixes the []= syntax
  2. routes the.= syntax through []=
  3. drys up sub-element creation such that each callsite only needs to specify the options it is overriding
  4. removes the Ruby 1.9 backport

the external api should not change at all

@fledman fledman changed the title dry internal handling of options & sub-element creation fix sub-element bug and dry internal handling of options Sep 20, 2018
@fledman
Copy link
Contributor Author

fledman commented Sep 20, 2018

@aetherknight some changes ready for review

@aetherknight
Copy link
Owner

I attempted to resolve a merge conflict on this PR using Github's online merge conflict editor. However, the tests were still failing. Instead, I made a local branch and fixed up the branch there.

@fledman fledman deleted the dry_options_handling_and_subelement_creation branch June 22, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants