Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise NoMethodError if raise_on_missing option is enabled #76

Merged
merged 1 commit into from
May 28, 2024
Merged

Raise NoMethodError if raise_on_missing option is enabled #76

merged 1 commit into from
May 28, 2024

Conversation

IlyaUmanets
Copy link
Contributor

Why:

  • Sometimes it's helpful to raise this error when you call a method which is not defined
  • Especially, it's valuable for parsing JSON structure which might changed
  • to not miss nil value

@IlyaUmanets
Raise NoMethodError if raise_on_missing option is enabled
281566d 
Why:

* Sometimes it's helpful to raise this error when you call a method which is not defined
* Especially, it's valuable for parsing JSON structure which might changed
* to not miss nil value
@IlyaUmanets
Copy link
Contributor Author

@aetherknight, take a look please

@aetherknight
Copy link
Owner

LGTM -- it is optional, leaving default behavior to match ostruct. I'll get it merged and release soon.

@aetherknight aetherknight self-requested a review May 28, 2024 04:04
@aetherknight aetherknight merged commit 394b1eb into aetherknight:main May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aetherknight aetherknight Awaiting requested review from aetherknight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyaUmanets @aetherknight