Skip to content
This repository has been archived by the owner on Mar 4, 2025. It is now read-only.

derive Copy for HitData and adjust consumers #333

Closed
wants to merge 2 commits into from

Conversation

databasedav
Copy link

No description provided.

@databasedav
Copy link
Author

from discord https://discord.com/channels/691052431525675048/1038322714320052304/1243630594928279704

Copy doesn't change the perf of those structs, but it will make it a breaking change to add a non-copy type to them in the future.
Also want to be careful implementing it on types that are mutated, to prevent copying when moving is desired.
That can lead to the situation where you think you have mutated something, but you've actually just mutated a copy, and the original is unchanged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant