Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Account for viewport position in sprite backend #365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Account for viewport position in sprite backend #365

wants to merge 1 commit into from
+7 −1

Conversation

johanhelsing
Copy link
Contributor

Fixes #364

@andriyDev andriyDev mentioned this pull request Nov 14, 2024
Merged
github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this pull request Nov 14, 2024
@andriyDev @johanhelsing
Fix sprite picking backend not considering the viewport of the camera. (
4eaebd4 
#16386)

# Objective

- When picking sprites, the pointer is offset from the mouse, causing
you to pick sprites you're not mousing over!

## Solution

- Shift over the cursor by the minimum of the viewport.

## Testing

- I was already using the bevy_mod_picking PR for my project, so it
seems to work!
- I tested this on the sprite_example (making the camera only render to
part of the viewport), and it also works there.

## Notes

- This is just aevyrie/bevy_mod_picking#365 but
in Bevy form.
- We don't need to renormalize the viewport in any way since the
viewport is specified in pixels, so all that matters is that the origin
is correct.

Co-authored-by: johanhelsing <johanhelsing@gmail.com>
@andriyDev
Copy link

This has been merged into Bevy as bevyengine/bevy#16386

mockersf pushed a commit to bevyengine/bevy that referenced this pull request Nov 16, 2024
@andriyDev @johanhelsing @mockersf
Fix sprite picking backend not considering the viewport of the camera. (
d2debf2 
#16386)

# Objective

- When picking sprites, the pointer is offset from the mouse, causing
you to pick sprites you're not mousing over!

## Solution

- Shift over the cursor by the minimum of the viewport.

## Testing

- I was already using the bevy_mod_picking PR for my project, so it
seems to work!
- I tested this on the sprite_example (making the camera only render to
part of the viewport), and it also works there.

## Notes

- This is just aevyrie/bevy_mod_picking#365 but
in Bevy form.
- We don't need to renormalize the viewport in any way since the
viewport is specified in pixels, so all that matters is that the origin
is correct.

Co-authored-by: johanhelsing <johanhelsing@gmail.com>
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Dec 2, 2024
@andriyDev @johanhelsing @ecoskey
Fix sprite picking backend not considering the viewport of the camera. (
c703dd0 
bevyengine#16386)

# Objective

- When picking sprites, the pointer is offset from the mouse, causing
you to pick sprites you're not mousing over!

## Solution

- Shift over the cursor by the minimum of the viewport.

## Testing

- I was already using the bevy_mod_picking PR for my project, so it
seems to work!
- I tested this on the sprite_example (making the camera only render to
part of the viewport), and it also works there.

## Notes

- This is just aevyrie/bevy_mod_picking#365 but
in Bevy form.
- We don't need to renormalize the viewport in any way since the
viewport is specified in pixels, so all that matters is that the origin
is correct.

Co-authored-by: johanhelsing <johanhelsing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sprite picking is offset when Camera::viewport is set
2 participants
@johanhelsing @andriyDev