Include window scale factor in viewport offset calculation #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with
bevy_mod_picking
I noticed that pick events are not triggered when I work with a viewport positioned with an offset relative to the window. I tracked issue down to this package. One can reproduce the issue by runningmouse_picking
example on a high density display: the rays will not match with mouse cursor.Turns out, the viewport offset calculation doesn't take into account pixel density of the screen. We have access to this information in
Window
though. So I make an assumption that we are working with the primary window, and pass the object down to the offset calculation.I also borrowed helper code for
low_latency_window_plugin
frombevy_mod_picking
while at it.This PR fixes one of the root issues #91 tried to fix symptoms for.
Closes #93