Format bubble value & updatePositionOnTap #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, please add a new sample in the example project using the new properties you added. |
Can I update to the sample13? |
|
Or you can create sample14
…On Fri, Apr 24, 2020, 10:29 AM Kris ***@***.***> wrote:
Great, please add a new sample in the example project using the new
properties you added.
Can I update to the sample13?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#80 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3UHTKBILUEIWTD4F7KTROGV47ANCNFSM4MQF737A>
.
|
|
@diegoveloper : new sample have been added ;) |
|
Thanks @ltdangkhoa it looks great! one thing before merging it , change the PR to dev instead of master. |
|
@diegoveloper Is it ok for the dev branch? |
|
Yes, point to dev branch, it looks like it has some conflicts |
|
@ltdangkhoa please check the conflicting files before the merge |
|
@diegoveloper Sorry I'm not good at git merging. Is it okay right now? |
|
@ltdangkhoa thanks !! |
|
You're awesome guys!! Is already possible to use this new features? where can i found some examples? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added 2 new options for this package:
The ability to format value in bubble indicator by using NumberFormat from intl package: Eg: 123456789.01 -> 123,456,789.01
While experience current package, I've found that the long press gesture to display bubble indicator on each point would not easy for end-user. The option updatePositionOnTap will solve that problem. However, there is a trade off with the ability to hide the indicator.
Above options are optional and keep the default behavior from master repository
Thanks