Added Dockerfile and docker-compose for web-only debugging/environment #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidh91
reviewed
Sep 17, 2024
Dockerfile
Outdated
| @@ -0,0 +1,17 @@ | |||
| FROM node:22 | |||
There was a problem hiding this comment.
I would tend to favor the fixed version as well to promote predictability, backwards compatibility and security. Using the latest tag would promote builds to non-lts versions which could introduce unwanted/unknown issues.
When updating versions, then the Dockerfile should simply be updated as well.
maidh91
reviewed
Sep 17, 2024
|
|
||
| RUN npm i -g pnpm | ||
|
|
||
| RUN curl https://sh.rustup.rs -sSf | sh -s -- -y |
There was a problem hiding this comment.
should the command be curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh
There was a problem hiding this comment.
That command initiated a cli based interactive installer. I tried a bunch of flags and ended up with this as the simplest method.
|
up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Dockerfile and docker-compose. These are useful if anyone wants to run the web-app side of the application without installing rust, tauri or pnpm.