Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Add src-core as the independent lib to any stack #88

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

maidh91
Copy link
Contributor

@maidh91 maidh91 commented Sep 10, 2024

Summary

  • Add src-core directory to contain Rust only code to handle all business logic
  • src-tauri contain commands only and setup to build desktop apps
  • Directory structure
wealthfolio/
├── src                   # React for frontend
├── src-tauri          # Tauri to build desktop apps
├── src-core          # Rust for backend

=> src-core is independent now, and can be reused in any tool (not just Tauri)

File changes

  • Most of the files are just moved from src-tauri to src-core
  • All dependencies (except tauri ones) are moved from src-tauri/Cargo.toml to src-core/Cargo.toml
  • Refactor all commands in src-tauri into a single place

@maidh91
Copy link
Contributor Author

maidh91 commented Sep 10, 2024

Hi @afadil

Could you please review this PR? This is only for refactoring to make the code cleaner.

Thanks!

@maidh91
Copy link
Contributor Author

maidh91 commented Sep 10, 2024

Hi @afadil

I have just rebased with latest main, can you review pls?

@afadil afadil merged commit e3c6b50 into afadil:main Sep 10, 2024
@afadil
Copy link
Owner

afadil commented Sep 10, 2024

Merged! Thank @maidh91

@maidh91 maidh91 deleted the src-core branch September 10, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants