Look ahead one step when building nested structures (#78) #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an array, we need to look at the next value in the path. Please run the tests without the patch in backbone-nested to see the bug in action. Thanks Closes afeld#78
| var attr = _.last(path); | ||
| var attrStr = Backbone.NestedModel.createAttrStr(path); | ||
|
|
||
|
|
|
We need to check the next item because otherwise, it'll assume that we're creating a regular object rather than an array, right? |
|
yeah thats how the bug came out if you did things came out ok, but if you did you'd see the bug Fixed the whitespace, thanks for seeing it |
|
👍 |
afeld
added a commit
that referenced
this pull request
Feb 19, 2014
Look ahead one step when building nested structures (#78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine whether a newly created nest-level should be an object or
an array, we need to look at the next value in the path.
Please run the tests without the patch in backbone-nested to see the bug
in action. Thanks
Closes #78