Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define abstract category, impredicatively #106

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

define abstract category, impredicatively #106

wants to merge 2 commits into from

Conversation

t6s
Copy link
Collaborator

@t6s t6s commented Mar 20, 2023

This PR adds a definition of abstract categories extending category.v.
Due to shortcomings in the constraint solver for universes in Coq,
this could only be done only for the impredicative version of monae.

Some compatibility changes are needed and made in imonae_lib to make it resemble more to analysis.boolp.

@affeldt-aist
Copy link
Owner

Should the changes in imonae_lib.v be also reported in monae_lib.v?
(It is easier for maintenance to these two files as similar as possible.)

@t6s
Copy link
Collaborator Author

t6s commented Jan 3, 2025

The only essential change in imonae_lib.v is the addition of funeqP, and it is not necessary for monae_lib.v since it is provided by boolp.v https://github.com/math-comp/analysis/blob/155492be64984449ebcdd79191ebdf5983fed60c/classical/boolp.v#L147

Do you suggest redefining it in monae_lib.v?

@affeldt-aist
Copy link
Owner

Do you suggest redefining it in monae_lib.v?

No, this wouldn't be a good idea in that case, but could left a comment, for I am sure that I will ask again in a few months ;-)

@t6s
Copy link
Collaborator Author

t6s commented Jan 3, 2025

Porting Arguments lines to monae_lib.v seems to be harmless.

@affeldt-aist
Copy link
Owner

Maybe you want to double-check this PR while you rebase,
because Florent has been contributed a few changes to category.v (that have been merged in master),
they are perhaps worth backporting in icategory.v.

@t6s
Copy link
Collaborator Author

t6s commented Jan 3, 2025

It think this PR should be anyway turned into a draft.
(or perhaps abandoned since the original goal to define functor categories has not been achieved even by impredicativity.)

@affeldt-aist affeldt-aist marked this pull request as draft January 3, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants