Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking ansicolor! #140

Open
mattvonrocketstein opened this issue Dec 12, 2017 · 1 comment
Open

breaking ansicolor! #140

mattvonrocketstein opened this issue Dec 12, 2017 · 1 comment

Comments

@mattvonrocketstein
Copy link

mattvonrocketstein commented Dec 12, 2017

First, this theme is amazing.. thank you very much for making jenkins-classic look presentable. I can't give up this awesomeness, but I think CSS might be breaking the ansicolor plugin which I also can't live without. Bold styles seem to have some kind of support, but colors get lost in my output on my chrome.

I'm using this CDN link: https://cdn.rawgit.com/afonsof/jenkins-material-theme/gh-pages/dist/material-blue-grey.css

From my debugger I see this for CSS classes

-output, .console-output * {
    position: relative;
    font-family: Roboto Mono,monospace!important;
    font-size: 14px;
    background: #263238;
    color: #e9eded;
    cursor: text;
}

Turning off this mention of "color"above wrecks the visibility of uncolored console text , but does bring back color text as expected.

The jenkins ANSI color plugin is generating ansi-to-html that looks for instance like this: <span style="color: #00CD00;"><b>green</b></span>

It shouldn't matter since I think the problem is conflicting CSS, but I'm using python's colored module for generating the console colors (I've also tried with colorama previously)

@Sylwekqaz
Copy link

It seems to me that the problem is through universal selector. Universal selector select all nested objects, and it's hard to overwrite this rule. Changing -output, .console-output * to -output, .console-output pre solves the problem

Sylwekqaz pushed a commit to Sylwekqaz/jenkins-material-theme that referenced this issue Jul 26, 2018
ruslan-khalitov added a commit to ruslan-khalitov/jenkins-material-theme that referenced this issue Sep 5, 2019
aldemira added a commit to aldemira/jenkins-material-theme that referenced this issue Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants