Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in client IDs / API keys for Trakt, Discord, and TMDB #46

Closed
rollingmoai opened this issue Jan 21, 2023 · 6 comments · Fixed by #73 or #80
Closed

Built-in client IDs / API keys for Trakt, Discord, and TMDB #46

rollingmoai opened this issue Jan 21, 2023 · 6 comments · Fixed by #73 or #80

Comments

@rollingmoai
Copy link

rollingmoai commented Jan 21, 2023

📝 Provide a description of the new feature

It would be more convenient if Discrakt used preset client IDs for Trakt and Discord. You would not need to do the Setup process. Just setup the Trakt user (or a --user flag for a no-config process) and run the application.

➕ Additional Information

Related to #24

@afonsojramos
Copy link
Owner

This doesn't even make sense. You can't have a default discord client id nor can you have a generic Trakt ID, it needs to be personal.

@afonsojramos afonsojramos closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2023
@rollingmoai
Copy link
Author

rollingmoai commented Feb 9, 2023

@afonsojramos I'm not sure about trakt, but you can make your own Discord application and hard code the value in the program by default (if you want an example, here). That's how most programs do it. Please reconsider.

@sitiom
Copy link
Contributor

sitiom commented Feb 9, 2023

See trakt-scrobbler, the application ID is built-in too (https://github.com/iamkroot/trakt-scrobbler/blob/master/trakt_scrobbler/trakt_key_holder.py)! You would just have to setup an auth flow for the app (https://github.com/iamkroot/trakt-scrobbler/blob/master/trakt_scrobbler/trakt_auth.py).

@afonsojramos afonsojramos reopened this Feb 9, 2023
@afonsojramos
Copy link
Owner

Ah, I see. Both do sound like they'd be separate issues though. And they do add some extra boilerplate, but it would make some stuff definitely easier to work with.

@afonsojramos
Copy link
Owner

@rollingmoai already hard coded the discord client id, thanks for the tip!
@sitiom I am a bit confused by that. In my mind the secret is supposed to be, as the name implies, secret. Is that not the case for Trakt Apps due to the necessity of OAuth?

@rollingmoai rollingmoai changed the title Built-in client IDs for Trakt and Discord Built-in client IDs / API keys for Trakt, Discord, and TMDB Mar 6, 2024
@sitiom
Copy link
Contributor

sitiom commented Mar 6, 2024

@sitiom I am a bit confused by that. In my mind the secret is supposed to be, as the name implies, secret. Is that not the case for Trakt Apps due to the necessity of OAuth?

I just tried the latest version, and it seems like setting the client secret is not necessary for OAuth to work. See: https://security.stackexchange.com/questions/76351/whats-the-point-of-the-client-secret-in-oauth2-if-it-doesnt-need-to-be-used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants