Dynamic Movie/Show Images from TMDB

[xBiei]

📑 Description

Well, because I hate the trakt logo and the other 2 logos for shows and movies because they look ugly and unrelated to whatever I'm watching, and discord now accepts urls in RPC images I figured we should use TMDB resources to improve the quality of this app.

Also, other than being able to use dynamic images, this PR won't change the dependencies at all.
And of course, if the app failed to use dynamic images, it'll fallback to the old ones.
Closes #25

✅ Checks

• code: My pull request adheres to the code style of this project
• docs: Added / updated
• tests: All the tests have passed

[DareFox]

Kinda awkward to have two same PR (#42) 😅

[rollingmoai]

Duplicate of #42

[xBiei]

Yeah I know lol
Both are doing the same thing so it probably doesn't matter which is used
I just PR-ed the one I use

[rollingmoai]

Side note: Have you even checked existing PRs before making yours? It's like reinventing the wheel 😅

[xBiei]

Side note: Have you even checked existing PRs before making yours? It's like reinventing the wheel 😅

I did actually. Submitted it anyway. :3

Edit: The reason I submitted mine is because I think it's better in some ways. You can check the code yourself. No extra dependencies, Readme updated and actually faster.

[afonsojramos]

Sorry for the absence, it seems I wasn't properly notified about both PRs.
I'll evaluate which one to merge today, and thank you both for you contributions @xBiei @DareFox!

While you're here @DareFox (since @xBiei already voiced their opinion), do you believe one has advantages over the other?

Side note: I actually also tried to fix #25, but I was using IMDB which for some reasons was causing some issues, which I never got around to. Eventually, I just pushed everything I had locally as I was switching computers, and then never got around to continuing the work. So again, thanks for your contributions!

[afonsojramos]

@xBiei @DareFox The way I see it, there are two clear distinctions between the two PRs.

The advantage to @DareFox's PR I suppose is a two way sword. Because it uses tmdb crate which makes the code cleaner, however we are adding a dependency for just two URLs.

This PR has caching for the image links, which I think is a great advantage, doesn't use any additional crates

So, in the end, I think I will close #42, and move forward with this one.

What I would improve on would be to also have a "disposable" tmdb token for quick usage, what do you think?

I still need to further test this implementation however, especially to test the situations where the image is not found.

Note: There are some clippy annotations that I would also fix.

[xBiei]

What I would improve on would be to also have a "disposable" tmdb token for quick usage, what do you think?

Yeah I agree, that would be good for the UX.

I still need to further test this implementation however, especially to test the situations where the image is not found.

If there's no url response, it'll use the media's type as url which discord fetches from the uploaded images to the app in their portal.

Note: There are some clippy annotations that I would also fix.

I'll check that out later

[rollingmoai]

What I would improve on would be to also have a "disposable" tmdb token for quick usage, what do you think?

Yes, that would be a good idea alongside built-in client IDs for Trakt and Discord (#46)

[DareFox]

The advantage to @DareFox's PR I suppose is a two way sword. Because it uses tmdb crate which makes the code cleaner, however we are adding a dependency for just two URLs.

This PR has caching for the image links, which I think is a great advantage, doesn't use any additional crates

So, in the end, I think I will close #42, and move forward with this one

I agree, dependency just for url fetch is kinda ambigous and this PR is better. Also caching could save potential problem with burner token limit usage

What I would improve on would be to also have a "disposable" tmdb token for quick usage, what do you think?

It would be very cool, it will make less hassle with configuration

Also, I have one question with this PR (I can't test rn, because my setup is borked): Is poster cropped or has original size?
If not cropped, then Discord crops it and adds blur to it. I fixed it with this commit, and maybe you could apply this fix here too

[xBiei]

Also, I have one question with this PR (I can't test rn, because my setup is borked): Is poster cropped or has original size?

If not cropped, then Discord crops it and adds blur to it. I fixed it with this commit, and maybe you could apply this fix here too

Yeah I noticed it is cropped and kinda blurry.
I'll check it out.

[xBiei]

Looks like I got too busy and forgot about this lol.
It should be fine now.

[afonsojramos]

Thanks!