Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit entityselect even if entity is null so the React UI updates properly #783

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

vincentfretin
Copy link
Contributor

When you press escape it does AFRAME.INSPECTOR.selectEntity(null) but the entityselect event wasn't emitted so the UI didn't update properly, and the right panel stayed open instead of closing.
@dmarcos

@dmarcos
Copy link
Member

dmarcos commented Dec 17, 2024

Thank you!

@dmarcos dmarcos merged commit 0a8c2b6 into aframevr:master Dec 17, 2024
1 check passed
@vincentfretin vincentfretin deleted the emit-entityselect-null branch December 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants