Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots broken in 0.8.2 #3727

Closed
vectris-dev opened this issue Aug 12, 2018 · 2 comments
Closed

Screenshots broken in 0.8.2 #3727

vectris-dev opened this issue Aug 12, 2018 · 2 comments

Comments

@vectris-dev
Copy link

vectris-dev commented Aug 12, 2018

Description:

To reproduce issue open the hello world example and take a screenshot using ctrl + alt + s to take a regular screenshot or ctrl + alt + shift + s to capture an equirectangular panorama as documented at https://aframe.io/blog/screenshot/

Equirectangular screenshots are blank and and regular screenshots are now split screen and off center

Equirectangular screenshot:
screenshot-hello world a-frame-1534047324763

Regular screenshot:
screenshot-hello world a-frame-1534047315918

The off center issue is hard to see in the hello world example so here is one from my own project

screenshot-wikimmerse-1534046948967

@ngokevin
Copy link
Member

they're meant to be more taken from 2D, not in VR. Could try to patch perhaps, but maybe be messy

@vectris-dev
Copy link
Author

Ah fair enough, in previous versions I've taken screenshots in VR using the vive buttons and they've turned out great. Is the intention to only support 2D screenshots? If that's the case I'll close this.

ngokevin added a commit that referenced this issue Feb 5, 2019
Disable/Renable VR before taking screenshot. Don't make equirectangular quad children of the scene camera (fix #3337, fix #3727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants