Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit Full Screen TypeError: document not active #4136

Closed
sanjay-bhuva opened this issue Apr 24, 2019 · 3 comments
Closed

Exit Full Screen TypeError: document not active #4136

sanjay-bhuva opened this issue Apr 24, 2019 · 3 comments

Comments

@sanjay-bhuva
Copy link

sanjay-bhuva commented Apr 24, 2019 •
edited
Loading

Description:

  • A-Frame Version: 0.9.0
  • Platform / Device: Windows/Chrome 73.0.3
  • Reproducible Code Snippet or URL: Not able to reproduce

I am not able to reproduce the issue but it's reported on bugsnag. It looks like issue occures when an user tries to exit full screen. Please find the attachment for more details. Any help would be appreciated. Thanks!

document-not-active
@dmarcos
Copy link
Member

dmarcos commented Apr 25, 2019

Is it with WebVR or WebXR? What headset? What’s the error on console? Do you have a link where you saw the error?

@sanjay-bhuva
Copy link
Author

@dmarcos it's in WebVR. I can also reproduce now with Linux/Chrome 74.0.3729.108. Error occures, when an user clicks on exit VR. Here is the console output.

Screenshot from 2019-04-25 20-46-35

@sanjay-bhuva
Copy link
Author

sanjay-bhuva commented Apr 26, 2019 •
edited
Loading

@dmarcos here is the codepen having same issue - https://codepen.io/khlevon98/full/GzObKR

Repro Steps:

  1. Go to - https://codepen.io/khlevon98/full/GzObKR and keep console open
  2. Click on enter VR icon at bottom right
  3. Press ESC to exit from full screen
  4. See the console output

dmarcos added a commit to dmarcos/aframe that referenced this issue Apr 26, 2019
@dmarcos
Verify fullscreenElement before exiting fullscreen. Chrome m71+ retur…
557c7a6 
…ns error withouth this check (fix aframevr#4136)
ngokevin added a commit that referenced this issue Apr 26, 2019
@ngokevin
Merge pull request #4143 from dmarcos/checkFullscreenEl
86d9c5e 
Verify fullscreenElement before exiting fullscreen. Chrome m71+ returns error withouth this check (fix #4136)
nh2 pushed a commit to nh2/aframe that referenced this issue May 2, 2019
@dmarcos @nh2
Verify fullscreenElement before exiting fullscreen. Chrome m71+ retur…
e4e4d06 
…ns error withouth this check (fix aframevr#4136)
@sanjay-bhuva sanjay-bhuva mentioned this issue Aug 8, 2019
Closed
This was referenced Sep 8, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmarcos @sanjay-bhuva