unit test and minor fixes to tracked-controls #2396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Was looking at a controls bug and wanted to sweep up to add coverage.
Changes proposed:
.update()
to.updateGamepad()
method. Don't need.update()
handler since.updateGamepad()
is called every tick. Also to not call handlers from other handlers..handle*()
methods more consistent by having them all return a boolean..handleAxes()
not take an argument since it's a method and has access to component membersthis.previousAxis
tothis.axis
since it represents current axis and is not used for any delta calculations.previousButtonState = buttonStates[id] = buttonStates[id] || {}