Bump Three.js to r84 #2456
Merged
Bump Three.js to r84 #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… THREE.GLTFLoader specification
ngokevin
reviewed
Mar 5, 2017
src/core/a-assets.js
Outdated
| because of THREE.GLTFLoader specification. | ||
| */ | ||
| if (!responseType) { | ||
| var extension = ''; |
There was a problem hiding this comment.
I'd make this code a private exported function inferResponseType (src) and test on its own.
There was a problem hiding this comment.
Thanks for the comment.
What does 'test on its own' mean in this case?
There was a problem hiding this comment.
We can test the function by calling it directly rather than creating a-asset-item
There was a problem hiding this comment.
That's very useful. I will update.
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR bumps Three.js to r84.
Because of
THREE.GLTFLoaderspecification in r84 or newer,.gltfand.glbfiles need to be loaded asarraybuffer.I let
a-asset-itemautomatically setarraubufferresponse-type attribute for them.I think this automation is necessary because of
FYI,
THREE.GLTFLoaderin r84Changes proposed:
a-asset-itemdetects glTF files from their extensions and automatically setsarraybufferresponse-type attribute.