Fix deepEqual when comparing non Object instantiated objects #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
requested changes
Mar 20, 2017
src/utils/index.js
Outdated
| @@ -125,10 +125,13 @@ function deepEqual (a, b) { | |||
| var keysB; | |||
| var valA; | |||
| var valB; | |||
| var areBothObjects = a && b && a.constructor === Object && b.constructor === Object; | |||
There was a problem hiding this comment.
Should we evaluate these inline so that the if expression can lazy evaluate and possibly not have to do a && b check twice?
tests/utils/objects.test.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| /* global assert, suite, test */ | |||
| // var entityFactory = require('../helpers').entityFactory; | |||
tests/utils/objects.test.js
Outdated
|
|
||
| test('avoid deep equal of object that are not instantiated' + | ||
| 'with the Object constructor in order to avoid infinite loops', function (done) { | ||
| var el1 = entityFactory(); |
There was a problem hiding this comment.
Can we just do deepEqual(document.createElement('a-entity'), document.createElement('a-entity'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We end up in an infinite loop when a property of the type
selectorchanges value. Two HTML elements are passed through thedeepEqualfunction that runs ad infinitum since each entity references the components that reference the entity itself, that reference the components, that reference the entity...Changes proposed:
Deep equal only compares deeply if the passed objects are plain JS objects.