Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix videoPlayback html attributes #2610

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

esterlus
Copy link
Contributor

@esterlus esterlus commented Apr 21, 2017

Description:

Video tags assume that autoplay/controls should be set if absent from video elements.
This seems to deviate from the expected standard as described here:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video#Attributes

webkit-playsinline is superseded by playsinline and should be set as well

Changes proposed:

  • adhere autoplay and controls attributes if not set (do not automatically assume autoplay / controls is intended)
  • check video tag correctly and set playinline where webkit-playsinline is set

check video tag correctly and set playinline where webkit-playsinline is
set
@ngokevin
Copy link
Member

Thanks!

@ngokevin ngokevin merged commit fe5e4c0 into aframevr:master Apr 21, 2017
@esterlus esterlus deleted the este/videoPlayback branch January 31, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants