no longer auto-enter-vr #2707
Closed
no longer auto-enter-vr #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a GearVR around. Can anyone verify that this fix the issue? |
|
I am a little confused over whether this is still a problem or not given #2659 versus the comment referenced above. Wondering if recent changes in oculus browser caused regression... |
|
Using the anime UI example from a-frobot examples link, with the latest version 3.3.2 of Oculus Browser, the example behaves as expected without this change. |
|
Closing for now as we don't seem to need it at present |
|
Reopening temporarily in case it is needed for #2614 |
|
Closing for now, can re-open if there's a need for this, but I don't know the details. |
This was referenced Jun 14, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Oculus Browser has a user interface both out of VR and inside VR, and effectively deprecates the previous Carmel Developer Preview which only worked in VR (and thus required auto-entering VR to be usable), remove the
auto-enter-vrcomponent from the default list of scene components. To keep the prior behavior, authors need only specify the component explicitly e.g.a-scene auto-enter-vrHopefully this will fix issues encountered such as #2614 (comment)