check if component is initialized before removing

[ngokevin]

Description:

Was running into errors in unit test if you detached an entity while one of its components was still initializing. Its data would be null because it had not yet built data, and .removeComponent would be called. Geometry would then be calling system.unuseGeometry(data) where data was null, causing an error.

Changes proposed:

• Wait for componentinitialized in removeComponent if not initialized.

[dmarcos]

What about doing just?

 if (!component || !component.initialized) { return; }

[ngokevin]

Then the removeComponent call will never go through. A warning might be simpler though.

[ngokevin]

Maybe it's best to try to make sure that component gets cleaned up. Might cause leaks or unexpected behavior if we let it be orphaned in the case entities are being attached/detached before the component initializes?

[dmarcos]

Asynchrony might bite you. What happens if you do:

myMethod () {
this.setAttribute('my-component', { });
this.removeAttribute('my-component');
this.setAttribute('my-component', {});
}

I believe the component will be removed if the component was not initialized in the first call

[ngokevin]

Initialization is already synchronous. After you do setAttribute, the component will be initialized immediately and thus the code I added will never run.

This PR is only in the case when you do appendChild/removeChild because that's inherently asynchronous, no way around it.

[cvan]

@ngokevin: sorry, I think Waffle automatically added that on my behalf