Fixed issue where light fails to set already loaded target #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarcos
reviewed
Jun 1, 2017
src/components/light.js
Outdated
| onSetTarget: function (targetEl) { | ||
| this.light.target = targetEl.object3D; | ||
| onSetTarget: function (targetEl, light) { | ||
| if (this.light) { this.light.target = targetEl.object3D; } |
There was a problem hiding this comment.
Can we just rely on the light parameter? Do we need to check both this.light and light?
light.target = targrtEl.object3DThere was a problem hiding this comment.
@dmarcos Right, I made a simplification and all tests still pass.
… already loaded. Added fix for the issue, so the newly created light gets the target set.
RSpace
force-pushed
the
loaded-light-target
branch
from
4e97a64 to
bb675f1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
By switching out models and lights dynamically in a scene, I have exposed an issue in the light component where a null reference exception occurs when creating a new spot or directional light where the target is already loaded.
setLightcallsgetLightwhich callsonSetTarget.onSetTargetexpectsthis.lightto be present, which works as long as the target is not loaded, since an event listener is set up ingetLight, givingthis.lighttime to get set insetLight. When the target is not loaded, however,onSetTargetis called immediately andthis.lightis undefined.Changes proposed:
onSetTargetwith the new light to set the target on, instead of relying onthis.lightContinue to also set target onthis.lightif present (this was necessary to get all tests passing, not sure why)