Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] a-text.md, raycasting #2871

Merged
merged 3 commits into from
Jul 17, 2017
Merged

[doc] a-text.md, raycasting #2871

merged 3 commits into from
Jul 17, 2017

Conversation

andreasplesch
Copy link
Contributor

Description:
address raycasting
Changes proposed:

  • add a limitations sections with a short explanation.

@dmarcos
Copy link
Member

dmarcos commented Jul 15, 2017

We have a cursor example (https://github.com/aframevr/aframe/blob/master/examples/test/cursor/index.html). Do we add some text there to illustrate how to do it?

@machenmusik
Copy link
Contributor

I think the a-plane labeled with text in https://github.com/aframevr/aframe/blob/master/examples/test/text/scenarios.html would work with cursor, right? If so, maybe we can point at something like that as example.

Copy link
Member

@ngokevin ngokevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase like, to interact with the text via raycaster or cursor, we will need to add a geometry like a plane to the text

@machenmusik
Copy link
Contributor

Yeah, IMO the core text component should be thought of more as a specific type of material / decoration and so to be interacted with, the entity needs a geometry (e.g. plane or box) that defines its area / volume for interaction...?

@andreasplesch
Copy link
Contributor Author

A simplistic example on the page may suffice ?

<a-text value="Hello, World!"></a-text>

<!-- for cursor detection add geometry -->

<a-text value="click me!" geometry="primitive:plane"></a-text>

@andreasplesch
Copy link
Contributor Author

The wording is friendlier now although I think it is preferable to say explicitly that text itself does not work with cursor or raycaster to avoid any confusion.

@@ -14,6 +14,10 @@ Wraps the [text component][text].

```html
<a-text value="Hello, World!"></a-text>

<!-- for interactivity add geometry -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add this example below to the limitations, and then:

<a-text value="Now interactable" geometry="primitive: plane"</a-text>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Not sure if interactable is a proper word but it is better than interactive.

@ngokevin ngokevin merged commit c2b720a into aframevr:master Jul 17, 2017
@andreasplesch andreasplesch deleted the patch-2 branch July 17, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants