-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cursor event listeners to canvas, not window #3179
Conversation
Another option would be to register those I thought it was odd they were on the window the last time I was in there. Perhaps just an artifact of the merge from the previous mouse cursor component. |
Thanks, better idea. |
Needs another review due to changing the solution. |
The problem with this approach is that if you have an embedded scene that it's small on screen it won't be a good experience. |
Oh sorry. looking at wrong file |
Failing tests |
Fixed. The embedded scene example works fine, same as before for me. |
Description:
Cursor only cares about actual touch events.
This fixes an issue where vive-controls touchstart bubbled up to window and cursor was receiving them.