Use component event handlers insted of bound a-scene methods #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngokevin
reviewed
Nov 1, 2017
src/components/scene/vr-mode-ui.js
Outdated
| @@ -55,10 +61,10 @@ module.exports.Component = registerComponent('vr-mode-ui', { | |||
| if (this.enterVREl || this.orientationModalEl) { return; } | |||
|
|
|||
| // Add UI if enabled and not already present. | |||
| this.enterVREl = createEnterVRButton(this.enterVR); | |||
| this.enterVREl = createEnterVRButton(this.onEnterVRButtonClick.bind(this)); | |||
ngokevin
reviewed
Nov 1, 2017
src/components/scene/vr-mode-ui.js
Outdated
| * Create a modal that tells mobile users to orient the phone to landscape. | ||
| * Add a close button that if clicked, exits VR and closes the modal. | ||
| * Creates a modal dialog to request the user to switch to landscape orientation. | ||
| * * |
ngokevin
reviewed
Nov 1, 2017
src/components/scene/vr-mode-ui.js
Outdated
| @@ -46,6 +44,14 @@ module.exports.Component = registerComponent('vr-mode-ui', { | |||
| bind(this.toggleOrientationModalIfNeeded, this)); | |||
| }, | |||
|
|
|||
| onModalClick: function () { | |||
There was a problem hiding this comment.
docstrings (Exit VR when modal clicked. - Enter VR when VR button clicked.)
ngokevin
approved these changes
Nov 1, 2017
dmarcos
force-pushed
the
useEvtHandlers
branch
from
df216d6 to
717f1f3
Compare
dmarcos
force-pushed
the
useEvtHandlers
branch
from
717f1f3 to
3317348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is more hygienic to use dedicated event handlers than directly wrapped methods of
a-scene. This became a problem with some experiments that were attempting at wrappinga-scenemethods.