Fix material array handling in shadow component #3348
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes material array handling in shadow component.
In Three.js r89,
mesh.material
can beTHREE.*Material
or array ofTHREE.*Material
.THREE.MultiMaterial
is already deprecated, it's converted to material array.So we should check if
mesh.material
is array instead.Question: Is var name
meshWithMaterialArray
in the test too long?Changes proposed:
node.material
instead ofnode.material.materials
for material array in shadow component.