Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix material array handling in shadow component #3348

Merged
merged 3 commits into from
Jan 23, 2018
Merged

Fix material array handling in shadow component #3348

merged 3 commits into from
Jan 23, 2018

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Jan 22, 2018

Description:

This PR fixes material array handling in shadow component.

In Three.js r89, mesh.material can be THREE.*Material or array of THREE.*Material.

THREE.MultiMaterial is already deprecated, it's converted to material array.

So we should check if mesh.material is array instead.

Question: Is var name meshWithMaterialArray in the test too long?

Changes proposed:

  • use node.material instead of node.material.materials for material array in shadow component.

@ngokevin ngokevin merged commit 485c1f6 into aframevr:master Jan 23, 2018
@takahirox takahirox deleted the FixShadowComponent branch February 24, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants