Wrap render method in case of spectator camera to render spectator view after vrDisplay.submitFrame (fix #3541) #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew after vrDisplay.submitFrame (fix aframevr#3541)
dmarcos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We moved the tock call to the THREE
onAfterRendercallback breaking spectator camera. the tock methods are now invoked between the render call andvrDisplay.submitFrame. The spectator camera has to render on the 2D view after the frame submission. This patch wraps the render method of the renderer to ensure the correct order in case a spectator camera is present.